feat: Add CSRF protection for gateway WebSocket#60
Merged
Conversation
Adds CSRF token generation and validation for gateway control messages from @aecs4u (PR #21). ## Features ### CsrfStore In-memory token store with automatic TTL expiry: - Issues 32-byte cryptographically random tokens (URL-safe base64) - Configurable TTL (default: 1 hour) - Automatic pruning of expired tokens - Thread-safe token validation ### Usage ```rust use rustyclaw::gateway::csrf::CsrfStore; let mut store = CsrfStore::default(); // Issue token in hello frame let token = store.issue_token(); // Validate on control messages if !store.validate(&token) { return Err("Invalid CSRF token"); } ``` ### Integration Points - Gateway issues token in hello frame - TUI/CLI stores token from hello response - Control messages (reload, elevated, etc.) include token - Gateway validates before processing ## Dependencies Added - `rand = "0.9"` — Cryptographic random number generation ## Tests Included - Token length verification (32 bytes) - Fresh token validation - Expired token rejection ## Attribution Original implementation by @aecs4u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CSRF token generation and validation for gateway control messages from @aecs4u (PR #21).
Security Purpose
Prevents cross-site WebSocket hijacking attacks where a malicious webpage could:
Implementation
CsrfStore (
src/gateway/csrf.rs)Flow
helloframeUsage
Tests
Dependencies
rand = "0.9"— Cryptographic RNGAttribution
Original implementation by @aecs4u