Skip to content

Disable inconsistent second-level pseudo-elements. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xavierholt
Copy link
Collaborator

This is a "fix" for #137.

I added code to differentiate mesylate and acetyl pseudo-elements. This worked for the test case given in #137, but further testing showed it to be fairly unreliable; it often wouldn't correctly detect either group. So I've disabled the entire second pass of pseudo-element detection until we can add something more robust. The result is that mesylate now draws as H₃CO₂S or SO₂CH₃, which should be acceptable for now.

The test SMILES from the original bug report:

C1=C[N](N=C1)C2CN([S](C)(=O)=O)C2

Another one I was using:

CCCC(S(=O)(=O)C)CC(C(C)=O)CCCC

Copy link

netlify bot commented Mar 30, 2025

Deploy Preview for smilesdrawer-doc canceled.

Name Link
🔨 Latest commit b1ff9b1
🔍 Latest deploy log https://app.netlify.com/sites/smilesdrawer-doc/deploys/67e9a904cd1bac0008084e71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant