Log all processes, not just the victim #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting a process to kill, print a line for every process instead of just the selected victim. This follows the behavior of the kernel OOM killer, which logs a similar whole-system snapshot of memory usage when invoked.
Author
|
This verbose logging is critical when trying to diagnose situations where the application you care about on a system is killed while it was using a small percentage of the system's total memory. Aside: It's been over 10 years since I did anything in C. I'm willing to try to make any refinements necessary to get this to a mergeable state, but anything complicated might be beyond me. |
Owner
|
Thanks, I can understand that this can be helpful. But I think this should be enabled through a |
rfjakob
requested changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a process to kill, print a line for every process instead of
just the selected victim. This follows the behavior of the kernel OOM killer,
which logs a similar whole-system snapshot of memory usage when invoked.