Makefile: hardcode systemd unit installation path #329
Conversation
|
@cyrillkuettel can you test this? |
Makefile
Outdated
| BINDIR ?= $(PREFIX)/bin | ||
| MANDIR ?= $(PREFIX)/share/man | ||
| MAN1DIR ?= $(MANDIR)/man1 | ||
| SYSCONFDIR ?= $(PREFIX)/etc |
There was a problem hiding this comment.
Also change this back to just "/etc" ? It's a little confusing if the config file earlyoom.default is not stored in /etc.
There was a problem hiding this comment.
If earlyoom.default is meant to be read by earlyoom main program, then this file and the main program should point to the same PREFIX, e.g. /usr/local.
The systemd service is meant to be read by the external systemd, therefore it will be put in another location not necessarily equal to the PREFIX of earlyoom - usually /etc/systemd/system/.
Is there anything wrong with the above?
There was a problem hiding this comment.
Yes, earlyoom.default is read by systemd, here: https://github.com/rfjakob/earlyoom/blob/master/earlyoom.service.in#L6
There was a problem hiding this comment.
But the Makefile deals with SYSCONFIDIR in other places:
Line 52 in 04e93de
But let's do as you suggested.
There was a problem hiding this comment.
Yeah it will work, but I find it confusing to have the config file for /etc/systemd/system/earlyoom.service in /usr/local . Thanks!
The path can't be relative to PREFIX, because of systemd. Sources: - systemd/systemd#19414 - https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html
2 participants
The path can't be relative to PREFIX.
This is how things work with systemd...
Sources:
Closes #327