Conversation
|
|
||
| The number of chromatograms in the `Chromatograms` object is reduced. | ||
|
|
||
| Note that for `ChromBackendSpectra`, when you subset the `Chromatograms` object, |
There was a problem hiding this comment.
i might remove this, realizing now im overexplaining a bit this whole index thing..
jorainer
left a comment
jorainer
left a comment
There was a problem hiding this comment.
Some minor things, suggestions and comments.
Also, a more general discussion:
-
Chromatogramsare per definition sorted by retention time, right? and that is also explained prominently (in the documentation and vignette)? -
I'm wondering whether it would not be easier for the Spectra backend to order the results of any calculation/extraction of intensity/retention time values than ordering the actual
Spectraobject? the results should benumericvectors of rtime and intensity values and ordering them would be less expensive compared to ordering aSpectraobject.
mm do you mean the peaksData of a single chromatogram ? because that's yes. |
jorainer
left a comment
jorainer
left a comment
There was a problem hiding this comment.
Really nice work @philouail ! I have only some minor comments and suggestions.
R/ChromBackendSpectra.R
Outdated
| #' all data into memory. | ||
| #' | ||
| #' **Factorize and Subsetting**: The `factorize()` method updates the | ||
| #' `chromSpectraIndex` in both `chromData` and the `spectra` object to reflect |
There was a problem hiding this comment.
If you mean the actual Spectra object you should write Spectra, not spectra. If you mean the slot, you could actually also write @spectra or write that it's the Spectra stored in the internal @spectra slot? Actually, the same/similar thing maybe also for the chromData - and all other internal slots
There was a problem hiding this comment.
ok i went through the package and tried to follow this.
|
|
||
| The number of chromatograms in the `Chromatograms` object is reduced. | ||
|
|
||
| Note that for `ChromBackendSpectra`, when you subset the `Chromatograms` object, |
3 participants
No description provided.