nNA addToObject argument#254
Closed
leopoldguyot wants to merge 6 commits intorformassspectrometry:masterfrom
Closed
nNA addToObject argument#254leopoldguyot wants to merge 6 commits intorformassspectrometry:masterfrom
leopoldguyot wants to merge 6 commits intorformassspectrometry:masterfrom
Conversation
…ts stored in the global colData)
Collaborator
Author
|
I just noticed that this implementation is not robust. Indeed it stores the pNA and nNA related to samples in the global colData. The problem is that pNA and nNA are set dependent. This can be an issue when someone wants to compute missingness metrics on sets that share colnames (ie. peptide and protein level set). I can't think of a way to store the set-wise pNA and nNA without using a set-wise colData? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#253 for context