feat: Constraint debug overlay (WIP)#46
Draft
ladvoc wants to merge 12 commits into
Draft
Conversation
1egoman
reviewed
Jun 8, 2026
Comment on lines
+129
to
+131
| // Stable key vertices used for endpoint resolution and inferred constraints. | ||
| // Unlike vertexIds, this does not receive inserted split vertices. | ||
| constraintVertexIds: ConstraintVertexIds; |
Contributor
There was a problem hiding this comment.
Ooh, very nice - this will also really come in handy in reconstrain, and I think allow for some latent bugs to be fixed in there in the vertex id -> sheet position mapping step!
Comment on lines
69
to
+74
| this.dcelDebugView = globalThis?.localStorage | ||
| ? globalThis?.localStorage.getItem('cad2d-dcel-debug-view') === 'true' | ||
| : false; | ||
| this.constraintDebugView = globalThis?.localStorage | ||
| ? globalThis?.localStorage.getItem('cad2d-constraint-debug-view') === 'true' | ||
| : false; |
Contributor
There was a problem hiding this comment.
FWIW - you maybe have come across this already but it but next.js really doesn't like this whole localStorage lookup pattern like this when server rendering. Honestly I really would like to just disable server rendering all together, I don't see it ever being important for this app. I think keeping this consistent for now with what already exists is good but if you have any better ideas here let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a constraint debug overlay modeled after DCEL debug overlay.