Handle incomplete restored run timers - #242
Open
hypnosiss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents restored run timers with incomplete start/end times from crashing the coordinator update loop.
When Home Assistant restores an in-progress irrigation run after a restart, the run can still be marked as running/paused while one of the timer boundaries is missing. In that state
update_time_remaining()currently attempts to subtractNonefromdatetime, which repeatedly raises:The fix treats these incomplete restored timers as expired, resets the timer counters, and lets the run queue continue cleaning itself up instead of keeping the event loop stuck on the exception.
Validation