Fix bug in deserializing JSON from the postgres adapter #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next.jdbc-suggested changes to make JSON decoding automatic apply to the whole JVM. If they're applied, then decoding metadata off of features will fail because the adapter has been assuming it's being handed a raw postgres object and calling `.getValue.` This patch makes the decoding more defensive, and lets it fail gently, since right now the only metadata examined at all is the `:expires-at` key. If we miss decoding this, then we just don't get expiry warnings. Fixes #3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next.jdbc-suggested changes to make JSON decoding automatic apply to the whole JVM. If they're applied, then decoding metadata off of features will fail because the adapter has been assuming it's being handed a raw postgres object and calling
.getValue.This patch makes the decoding more defensive, and lets it fail gently, since right now the only metadata examined at all is the
:expires-atkey. If we miss decoding this, then we just don't get expiry warnings.Fixes #3.