Heroicons v2 #5
Open
Heroicons v2 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For those of you who want to use v2 now, I have created a temporary npm package until v2 support is merged in this repo.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been wanting to use Heroicons v2 in my projects and thought I would give closing #3 a shot. I hope that's ok.
I included a reference table in the readme derived from the Heroicons v2 release notes to make it easier to reference during migration. I suppose we could eventually re-export an alias of the old name in an index file somewhere to make it seemless but that isn't included in this PR.
Versioning
Since there a number of breaking changes as well as a unique icon set from v1, it may be a good idea to bump major versions of this repo to
1.0.0and2.0.0to keep aligned with Heroicon's v1 and v2 respectively. It would make it easier to use the original icon set if need be. What do you think?Happy Coding!