Skip to content

Conversation

@RHRolun
Copy link
Collaborator

@RHRolun RHRolun commented Sep 30, 2024

  • New templates
  • Updated images
  • Updated langchain
  • Added missing image bucket env var

- New templates
- Updated images
- Updated langchain
- Added missing image bucket env var
@RHRolun
Copy link
Collaborator Author

RHRolun commented Sep 30, 2024

Closes #113 #114

Copy link
Collaborator

@rcarrata rcarrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

)

PROMPT = PromptTemplate.from_template(template)
prompt = PromptTemplate(input_variables=["car_claim"], template=template)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RHRolun why we're selecting only car_claim? will be only targeting this input_variable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the templates only have a single variable in them and it's "car_claim".


metadata = {
"claim_ids": 0,
"detection_endpoint": "https://some-endpoint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RHRolun is this expected to be this url, or it's just a mockup and any variable will work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mockup here, the users will enter the url to their served model when running the pipeline (this becomes default parameters which suggest the user what to enter)

@guimou guimou merged commit 057f210 into dev Sep 30, 2024
1 check failed
@guimou guimou deleted the fix/pipelines-with-granite branch October 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants