hw-accel: prepare remove of preflightvalidationocp crd#1056
Merged
cdvultur merged 1 commit intorh-ecosystem-edge:mainfrom Jun 16, 2025
Merged
hw-accel: prepare remove of preflightvalidationocp crd#1056cdvultur merged 1 commit intorh-ecosystem-edge:mainfrom
cdvultur merged 1 commit intorh-ecosystem-edge:mainfrom
Conversation
klaskosk
previously approved these changes
Jun 13, 2025
Collaborator
klaskosk
left a comment
klaskosk
left a comment
There was a problem hiding this comment.
some nits and a warning about the Exists method, but overall looks good and we'll end up resolving the warning with the common methods next release anyway
cdvultur
force-pushed
the
kmm-add-preflightvalidation
branch
from
a8dbbff to
5b6f8ab
Compare
klaskosk
approved these changes
Jun 16, 2025
Collaborator
|
Integration test failure is something I need to look at and stabilize so we can ignore it for now |
Collaborator
Author
|
Wondered why it failed, given that locally |
sebrandon1
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
release-2.4of KMM will drop thepreflightvalidationocpcrd.The tests will be moved to the u/s crd:
preflightvalidationThis PR is a precursor of the crd removal and assures that there are no breakages.