pod: add unit test for executor#602
Draft
edcdavid wants to merge 1 commit intorh-ecosystem-edge:mainfrom
Draft
Conversation
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 1, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 5, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 5, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Apr 15, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Apr 15, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
May 10, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
May 10, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
added a commit
that referenced
this pull request
Jun 8, 2025
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and #602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a unit test for the pod remote executor