cluster: reliably execute commands

[achuzhoy]

Previous way of executing commands against nodes
doesn't seem to work properly anymore

Summary by CodeRabbit

• Tests
  • Improved image-based upgrade tests by simplifying output validation to a single-result check and updating the command execution path, reducing flakiness and making NTP source verification more reliable.

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaces line-by-line stdout processing with a single concatenated output string for NTP source verification and swaps the command helper from ExecCmdWithStdoutWithRetries to ExecCommandOnSNOWithRetries.

Changes

Cohort / File(s)	Summary
NTP Source Verification Refactor tests/lca/imagebasedupgrade/mgmt/upgrade/tests/e2e-upgrade-test.go	Replaces per-line stdout iteration with a single-string cmdOutput containment check for each NTP source; changes command helper from ExecCmdWithStdoutWithRetries to ExecCommandOnSNOWithRetries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• lca ibu: add retries to check ntp sources #1159 — Modifies the same NTP-source check in e2e-upgrade-test.go and changes the command-execution helper used for reading chrony configuration.

Suggested reviewers

• trewest

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'cluster: reliably execute commands' is clearly related to the main change—replacing command execution methods to use a more reliable helper function (ExecCommandOnSNOWithRetries instead of ExecCmdWithStdoutWithRetries).
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Command failed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@tests/internal/cluster/cluster.go`:
- Line 156: The hostnameCmd slice is incorrectly a single-element slice, so
ExecCommand will search for an executable named "chroot /rootfs sh -c 'printf
$(hostname)'"; update hostnameCmd to be a proper argv slice (e.g.
[]string{"sh","-c","chroot /rootfs sh -c 'printf $(hostname)'"} or split into
[]string{"chroot","/rootfs","sh","-c","printf $(hostname)"}) so ExecCommand
receives separate args, and leave the variable name hostnameCmd and the call
site to ExecCommand unchanged.