Skip to content

cnf ran: increase wait for labels in post-provision#1192

Open
klaskosk wants to merge 1 commit intorh-ecosystem-edge:mainfrom
klaskosk:increase-oran-label-wait
Open

cnf ran: increase wait for labels in post-provision#1192
klaskosk wants to merge 1 commit intorh-ecosystem-edge:mainfrom
klaskosk:increase-oran-label-wait

Conversation

@klaskosk
Copy link
Copy Markdown
Collaborator

@klaskosk klaskosk commented Feb 19, 2026

This commit increases the timeouts in the post-provision waitForLabels
function to be 5 minutes instead of 2. This was done for other timeouts,
but missed for this one.

Assisted-by: Cursor

Summary by CodeRabbit

  • Tests
    • Increased timeout durations in test scenarios to improve test stability and reduce false failures during provisioning validation checks.

This commit increases the timeouts in the post-provision waitForLabels
function to be 5 minutes instead of 2. This was done for other timeouts,
but missed for this one.

Assisted-by: Cursor
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Two timeout durations are increased from 2 minutes to 5 minutes in the ORAN post-provision test file, specifically for clusterInstance.WaitForExtraLabel and mcl.WaitForLabel operations within the waitForLabels function. No logic, control flow, or error handling changes are introduced.

Changes

Cohort / File(s) Summary
ORAN Post-Provision Test Timeouts
tests/cnf/ran/oran/tests/oran-post-provision.go
Increased two label-wait timeout values from 2 minutes to 5 minutes to allow more time for label propagation in test assertions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • yliu127
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: increasing wait timeout for labels in the post-provision function.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Command failed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant