cnf ran ptp: refactor OC 2 port 80963#1298
Draft
klaskosk wants to merge 1 commit intorh-ecosystem-edge:mainfrom
Draft
cnf ran ptp: refactor OC 2 port 80963#1298klaskosk wants to merge 1 commit intorh-ecosystem-edge:mainfrom
klaskosk wants to merge 1 commit intorh-ecosystem-edge:mainfrom
Conversation
This commit refactors the OC 2 port test 80963 to avoid a consistent failure we see in CI. The failover process is not instant, and may bounce into FREERUN briefly during the sync on the passive port. These are an artifact of how the feature works and not product bugs, so this commit updates the test to be less strict about these. Assisted-by: Cursor
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the OC 2 port test 80963 to avoid a consistent failure we see in CI. The failover process is not instant, and may bounce into FREERUN briefly during the sync on the passive port. These are an artifact of how the feature works and not product bugs, so this commit updates the test to be less strict about these.
Assisted-by: Cursor