test(kmm): add filesToSign webhook tests and secure boot scripts#1332
test(kmm): add filesToSign webhook tests and secure boot scripts#1332ybrodsky-rh wants to merge 2 commits intorh-ecosystem-edge:mainfrom
Conversation
Add webhook validation tests for filesToSign: reject Module with Sign but no filesToSign, and reject filesToSign paths outside dirName. Add hack/secureboot-enable.sh and hack/secureboot-disable.sh for toggling UEFI Secure Boot on KVM-based OCP clusters, supporting both local (CI) and remote (SSH) execution modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 28 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
filesToSign: reject Module withSignbut nofilesToSign, and rejectfilesToSignpaths outsidedirNamehack/secureboot-enable.shandhack/secureboot-disable.shfor toggling UEFI Secure Boot on KVM-based OCP clustersjob-runner-bash) and remote execution via SSH (HYPERVISOR_HOST)Test plan
ginkgo --label-filter="webhook"on a cluster with KMM deployedhack/secureboot-enable.shsuccessfully enables secure boot and enrolls signing cert on worker nodeshack/secureboot-disable.shrestores standard NVRAM and disables secure boot