system-tests: Update macvlan-validation.go to support IPv6 single stack

[laurayang842]

Summary by CodeRabbit

• Tests
  • Consolidated MACVLAN connectivity test validation logic to improve maintainability and reduce code duplication in test infrastructure.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39c186e7-278d-42eb-851b-0a8e33cd9bb5

📥 Commits

Reviewing files that changed from the base of the PR and between 4990ef3 and 8608c7d.

📒 Files selected for processing (1)

• tests/system-tests/rdscore/internal/rdscorecommon/macvlan-validation.go

---

📝 Walkthrough

Walkthrough

The PR introduces a new helper function verifyMACVLANTargets to consolidate repetitive MACVLAN connectivity verification logic in test code. Two existing functions are refactored to use this helper instead of multiple explicit verification calls.

Changes

Cohort / File(s)	Summary
MACVLAN Validation Refactoring tests/system-tests/rdscore/internal/rdscorecommon/macvlan-validation.go	Added new helper function verifyMACVLANTargets that iterates over non-empty IPv4/IPv6 targets and validates connectivity. Refactored VerifyMACVLANConnectivityBetweenDifferentNodes and VerifyMACVLANConnectivityOnSameNode to replace explicit verifySRIOVConnectivity calls with calls to the new helper.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: refactoring macvlan-validation.go to support IPv6 single-stack configurations by introducing a helper function that handles both IPv4 and IPv6 targets.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[laurayang842]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.