system-tests: update monitoring-config-validation for IPv6

[laurayang842]

Summary by CodeRabbit

• Tests
  • Updated test infrastructure to validate network connectivity across both IPv4 and IPv6 protocols.

[coderabbitai]

Warning

Rate limit exceeded

@laurayang842 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 36 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 40 minutes and 36 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a08fa93a-94cb-4bae-9efe-a384d4d721a4

📥 Commits

Reviewing files that changed from the base of the PR and between ea995a0 and 92ce0f8.

📒 Files selected for processing (1)

• tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go

📝 Walkthrough

Walkthrough

An embedded Python HTTP server script in the monitoring configuration validation test is updated to use a dual-stack TCP server. The server binding is changed from IPv4 to IPv6 with explicit dual-stack mode enabled, allowing concurrent IPv4 and IPv6 connections.

Changes

Cohort / File(s)	Summary
Dual-Stack HTTP Server Configuration tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go	Embedded Python HTTP server script updated to replace socketserver.TCPServer with DualStackTCPServer, binding on IPv6 unspecified address (::) with IPV6_V6ONLY disabled to enable dual-stack (IPv4+IPv6) connections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: updating monitoring-config-validation to support IPv6 with dual-stack functionality.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go (1)

493-503: Dual-stack switch looks correct; consider moving import socket to the top of the script.

The dual-stack approach (AF_INET6 + clearing IPV6_V6ONLY) is the standard way to accept both IPv4 and IPv6 connections on a single socket on Linux, so this should work for IPv6-enabled clusters while remaining compatible with IPv4. One minor stylistic nit: import socket is placed mid-script (line 493) rather than alongside the other imports at the top — relocating it keeps the embedded script idiomatic and easier to read.

♻️ Proposed cleanup

 import http.server
 import socketserver
 import json
 import threading
+import socket
 from urllib.parse import urlparse
@@
-import socket
-
 class DualStackTCPServer(socketserver.TCPServer):
     address_family = socket.AF_INET6

     def server_bind(self):
         self.socket.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 0)
         super().server_bind()

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go`
around lines 493 - 503, Move the "import socket" statement from its current
mid-file location into the top-level imports section so it's grouped with the
other imports; update the module import order near the top of the script and
leave the DualStackTCPServer class (address_family = socket.AF_INET6 and
server_bind using socket.IPPROTO_IPV6/socket.IPV6_V6ONLY) unchanged so the
class, server_bind method, and uses of socket constants still reference the same
symbol.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go`:
- Around line 493-503: Move the "import socket" statement from its current
mid-file location into the top-level imports section so it's grouped with the
other imports; update the module import order near the top of the script and
leave the DualStackTCPServer class (address_family = socket.AF_INET6 and
server_bind using socket.IPPROTO_IPV6/socket.IPV6_V6ONLY) unchanged so the
class, server_bind method, and uses of socket constants still reference the same
symbol.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 07baaa12-e68c-4f23-aaba-e7c29aca8db8

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb4bac and ea995a0.

📒 Files selected for processing (1)

• tests/system-tests/rdscore/internal/rdscorecommon/monitoring-config-validation.go

[yprokule]

/lgtm