cnf-network: fix HostNameLabel issue in ipforwarding tests

[evgenLevin]

Summary by CodeRabbit

• Tests
  • Updated label selectors in IP forwarding network tests for improved consistency and compatibility across node-targeting configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: baee40e8-b1bc-4444-a561-f643b9efe76d

📥 Commits

Reviewing files that changed from the base of the PR and between ad1dcfb and 75b15c8.

📒 Files selected for processing (1)

• tests/cnf/core/network/metallb/tests/ip-forwarding.go

---

📝 Walkthrough

Walkthrough

Updated node-targeting label selectors in an IP forwarding test file, replacing netparam.LabelHostName with corev1.LabelHostname across NNCP policy builders, MetalLB BGP peer node selectors, worker reboot configurations, and shared cleanup policies for both IPv4 and IPv6 test contexts.

Changes

Cohort / File(s)	Summary
Label Selector Constant Update tests/cnf/core/network/metallb/tests/ip-forwarding.go	Replaced netparam.LabelHostName with corev1.LabelHostname across NNCP policy builders, MetalLB BGP peer node selectors, worker reboot LabelSelector, and cleanup policy creation in IPv4/IPv6 test contexts (13 lines).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing a HostNameLabel issue in IP forwarding tests by updating label selectors from netparam.LabelHostName to corev1.LabelHostname.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Command failed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[klaskosk]

lgtm, thanks!