Skip to content

Add KServe inference test suite for Neuron#1356

Open
ybrodsky-rh wants to merge 3 commits intorh-ecosystem-edge:mainfrom
ybrodsky-rh:add-kserve-tests
Open

Add KServe inference test suite for Neuron#1356
ybrodsky-rh wants to merge 3 commits intorh-ecosystem-edge:mainfrom
ybrodsky-rh:add-kserve-tests

Conversation

@ybrodsky-rh
Copy link
Copy Markdown
Collaborator

Summary

  • Add new Ginkgo test suite under tests/hw-accel/neuron/kserve/ for validating KServe InferenceService deployment and inference on AWS Neuron hardware
  • Two test cases: kserve-001 (deploy InferenceService, wait for Ready) and kserve-002 (send inference request, validate response)
  • Add KServe inference helper (internal/do/kserve.go) using curl pod approach with retry for Neuron model compilation delays
  • Extend NeuronConfig with KServe-specific env vars (model name, namespace, vLLM image, tensor parallel size)

Dependencies

Test plan

  • Verify go build ./tests/hw-accel/neuron/kserve/... compiles (after eco-goinfra dependency is updated)
  • Run with label filter neuron && kserve on ROSA HCP cluster with RHOAI/KServe stack installed
  • Verify existing neuron && vllm and neuron && metrics tests are unaffected

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@ybrodsky-rh has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 40 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ddcc3b03-2b77-46ad-a5cd-bde678f4c2e4

📥 Commits

Reviewing files that changed from the base of the PR and between df020c0 and 84ea8a2.

⛔ Files ignored due to path filters (10)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/kserve/inferenceservice.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/kserve/servingruntime.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1alpha1/groupversion_info.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1alpha1/servingruntime_types.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1beta1/groupversion_info.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1beta1/inferenceservice_types.go is excluded by !vendor/**
  • vendor/github.com/rh-ecosystem-edge/eco-goinfra/pkg/schemes/kserve/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/modules.txt is excluded by !vendor/**
📒 Files selected for processing (6)
  • go.mod
  • tests/hw-accel/neuron/internal/do/kserve.go
  • tests/hw-accel/neuron/internal/neuronconfig/config.go
  • tests/hw-accel/neuron/kserve/internal/tsparams/consts.go
  • tests/hw-accel/neuron/kserve/kserve_suite_test.go
  • tests/hw-accel/neuron/kserve/tests/kserve-inference-test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 41 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ybrodsky-rh ybrodsky-rh added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2026
@ybrodsky-rh ybrodsky-rh marked this pull request as draft April 29, 2026 15:28
@ybrodsky-rh
Copy link
Copy Markdown
Collaborator Author

Blocked on dependency: This PR imports github.com/rh-ecosystem-edge/eco-goinfra/pkg/kserve which is introduced in rh-ecosystem-edge/eco-goinfra#1337. CI will fail until that PR is merged and this PR is rebased to pick up the new package.

Merge order:

  1. Add KServe InferenceService and ServingRuntime builders eco-goinfra#1337 (KServe builders)
  2. This PR (rebase after ibu mgmt: add proxy test to upgrade suite #1 merges)
  3. Add KServe inference E2E workflow for AWS Neuron openshift/release#78561 (Prow steps)

@ybrodsky-rh ybrodsky-rh marked this pull request as ready for review April 30, 2026 16:19
@ybrodsky-rh
Copy link
Copy Markdown
Collaborator Author

/retest

ybrodsky-rh and others added 2 commits April 30, 2026 19:26
Add a new Ginkgo test suite under tests/hw-accel/neuron/kserve/ that
validates KServe InferenceService deployment and inference on AWS
Neuron hardware with OpenShift AI.

Test cases:
- kserve-001: Deploy InferenceService and verify Ready state
- kserve-002: Send inference request and validate response

Depends on eco-goinfra KServe builders (rh-ecosystem-edge/eco-goinfra#1337).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant