Skip to content

lca ipc: update the dns validation#1357

Merged
achuzhoy merged 1 commit intorh-ecosystem-edge:mainfrom
achuzhoy:dns-check
Apr 30, 2026
Merged

lca ipc: update the dns validation#1357
achuzhoy merged 1 commit intorh-ecosystem-edge:mainfrom
achuzhoy:dns-check

Conversation

@achuzhoy
Copy link
Copy Markdown
Collaborator

@achuzhoy achuzhoy commented Apr 29, 2026

This change follows the upstream Kubernetes apimachinery update that now passes the real value to field.Invalid(), resulting in error messages like Invalid value: "192.168.130.261" instead of Invalid value: "string".

Summary by CodeRabbit

  • Tests
    • Refined DNS server configuration validation error messages to include the specific invalid IP address value, providing more informative feedback when misconfiguration occurs.

This change follows the upstream Kubernetes apimachinery update
that now passes the real value to field.Invalid(), resulting in
error messages like Invalid value: "192.168.130.261" instead of
Invalid value: "string".

Signed-off-by: Alexander Chuzhoy <achuzhoy@redhat.com>
@achuzhoy
Copy link
Copy Markdown
Collaborator Author

cc @trewest

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 28be6d32-21ae-4af2-8192-1401160f6789

📥 Commits

Reviewing files that changed from the base of the PR and between 2a82a3f and e06a065.

📒 Files selected for processing (1)
  • tests/lca/ipchange/tests/ipconfig-test.go

📝 Walkthrough

Walkthrough

A test case validation in the IP configuration test file is updated to use the actual bad IP value constant instead of a fixed substring reference when asserting expected error messages. One line of test assertion logic is modified.

Changes

Cohort / File(s) Summary
DNS Server Validation Test
tests/lca/ipchange/tests/ipconfig-test.go
Updated expected error message format for spec.dnsServers[0] validation to dynamically construct the error substring using tsparams.BadIPv4Address constant instead of a fixed string reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'lca ipc: update the dns validation' directly relates to the changeset, which updates a DNS validation test case to match an upstream Kubernetes change in error message formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@achuzhoy achuzhoy merged commit 3293572 into rh-ecosystem-edge:main Apr 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants