Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe pull request removes 84 lines of registry and mirror configurations from the disconnected task's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test e2e-disconnected |
|
Triggered: E2E Disconnected |
…es.conf LVMS, ODF, NVIDIA and RHOAI registry entries were hardcoded in the MCE custom-registries ConfigMap even when those plugins are not deployed. Remove them so the existing patch_mce_registries.yaml mechanism adds them dynamically only when the corresponding plugin is actually enabled. Also drops the legacy openshift-service-mesh-tech-preview and openshift-service-mesh-dev-preview-beta entries, which are no longer needed with servicemeshoperator3. Signed-off-by: Rafa Porres Molina <rporresm@redhat.com> Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
332c8e5 to
711b228
Compare
|
Tarball created: |
LVMS, ODF, NVIDIA and RHOAI registry entries were hardcoded in the MCE custom-registries ConfigMap even when those plugins are not deployed. Remove them so the existing patch_mce_registries.yaml mechanism adds them dynamically only when the corresponding plugin is actually enabled.
Also drops the legacy openshift-service-mesh-tech-preview and openshift-service-mesh-dev-preview-beta entries, which are no longer needed with servicemeshoperator3.
https://redhat.atlassian.net/browse/MGMT-23873
Summary by CodeRabbit