Skip to content

[WIP] multicluster-engine: remove plugin registries from hardcoded registries.conf#255

Open
rporres wants to merge 1 commit intomainfrom
remove-plugins-from-multicluster-engine-registries-conf-MGMT-23873
Open

[WIP] multicluster-engine: remove plugin registries from hardcoded registries.conf#255
rporres wants to merge 1 commit intomainfrom
remove-plugins-from-multicluster-engine-registries-conf-MGMT-23873

Conversation

@rporres
Copy link
Copy Markdown
Contributor

@rporres rporres commented Apr 15, 2026

LVMS, ODF, NVIDIA and RHOAI registry entries were hardcoded in the MCE custom-registries ConfigMap even when those plugins are not deployed. Remove them so the existing patch_mce_registries.yaml mechanism adds them dynamically only when the corresponding plugin is actually enabled.

Also drops the legacy openshift-service-mesh-tech-preview and openshift-service-mesh-dev-preview-beta entries, which are no longer needed with servicemeshoperator3.

https://redhat.atlassian.net/browse/MGMT-23873

Summary by CodeRabbit

  • Chores
    • Removed multiple unused registry and mirror entries from the multicluster engine disconnected configuration, trimming the configuration by 84 lines and simplifying registry mappings.

@github-actions github-actions Bot added the operators Operator installation/config label Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a6f39a7-acbb-4771-a191-02110fd804a8

📥 Commits

Reviewing files that changed from the base of the PR and between 332c8e5 and 711b228.

📒 Files selected for processing (1)
  • operators/multicluster-engine/tasks.yaml
💤 Files with no reviewable changes (1)
  • operators/multicluster-engine/tasks.yaml

Walkthrough

The pull request removes 84 lines of registry and mirror configurations from the disconnected task's registries.conf in operators/multicluster-engine/tasks.yaml. Registry entries removed include lvms4, odf4, rhceph, nvcr.io/nvidia, registry.connect.redhat.com/nvidia, rhcl-1, leader-worker-set, several openshift-service-mesh variants, rhoai, rhelai1, rhaiis, and rhods. Remaining registry/mirror blocks and task structure are unchanged.

Changes

Cohort / File(s) Summary
Registry Configuration Cleanup
operators/multicluster-engine/tasks.yaml
Deleted 84 lines: removed [[registry]] and [[registry.mirror]] blocks for multiple registries (see Walkthrough). Other registry entries and task control flow left intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing plugin registries from hardcoded registries.conf in multicluster-engine.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-plugins-from-multicluster-engine-registries-conf-MGMT-23873

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rporres
Copy link
Copy Markdown
Contributor Author

rporres commented Apr 15, 2026

/test e2e-disconnected

@github-actions
Copy link
Copy Markdown

Triggered: E2E Disconnected

@rporres rporres changed the title multicluster-engine: remove plugin registries from hardcoded registries.conf [WIP] multicluster-engine: remove plugin registries from hardcoded registries.conf Apr 17, 2026
…es.conf

LVMS, ODF, NVIDIA and RHOAI registry entries were hardcoded in the
MCE custom-registries ConfigMap even when those plugins are not deployed.
Remove them so the existing patch_mce_registries.yaml mechanism adds them
dynamically only when the corresponding plugin is actually enabled.

Also drops the legacy openshift-service-mesh-tech-preview and
openshift-service-mesh-dev-preview-beta entries, which are no longer
needed with servicemeshoperator3.

Signed-off-by: Rafa Porres Molina <rporresm@redhat.com>
Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@rporres rporres force-pushed the remove-plugins-from-multicluster-engine-registries-conf-MGMT-23873 branch from 332c8e5 to 711b228 Compare April 22, 2026 08:10
@github-actions
Copy link
Copy Markdown

Tarball created: quay.io/edge-infrastructure/enclave:b51e07c3777ee40fa7d80575f2e0a23d6501650a (b51e07c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

operators Operator installation/config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant