Skip to content

e2e-deployment trigger for 0-rc#282

Merged
maorfr merged 1 commit intomainfrom
e2e-0-rc-trigger
Apr 21, 2026
Merged

e2e-deployment trigger for 0-rc#282
maorfr merged 1 commit intomainfrom
e2e-0-rc-trigger

Conversation

@maorfr
Copy link
Copy Markdown
Collaborator

@maorfr maorfr commented Apr 21, 2026

this workflow was added in #280 matching main.
it was updated in #281 to match 0-rc.

this PR changes to workflow from running the workflow in main to triggering the workflow in 0-rc.

Summary by CodeRabbit

  • Chores
    • Simplified release candidate deployment workflow configuration for improved efficiency.

@github-actions github-actions Bot added the ci-cd CI/CD infrastructure label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The E2E RC deployment workflow is refactored to delegate its full deployment logic to another workflow. Previously a standalone job handling checkout, infrastructure provisioning, OpenShift deployment, and artifact collection; now a lightweight job that invokes e2e-deployment.yml with the RC branch reference, eliminating all conditional inputs and provisioning steps.

Changes

Cohort / File(s) Summary
Workflow Delegation
.github/workflows/e2e-deployment-rc.yml
Replaced full E2E RC deployment job with single gh workflow run trigger to e2e-deployment.yml --ref 0-rc. Removed workflow inputs (storage plugin, skip cleanup, Slack notification), deployment phases, artifact collection, and conditional logic. Simplified permissions to actions: write and environment to GH_TOKEN only.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: converting the e2e-deployment-rc workflow from a full job to a trigger that invokes the e2e-deployment workflow on the 0-rc branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch e2e-0-rc-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Tarball created: quay.io/edge-infrastructure/enclave:6cd5c474ce8d117b020b1d2de1a6314bf2693597 (6cd5c47)

@maorfr maorfr merged commit ed8287f into main Apr 21, 2026
19 of 20 checks passed
@maorfr maorfr deleted the e2e-0-rc-trigger branch April 21, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant