Skip to content

Add ODF E2E job to RC nightly schedule#285

Open
eliorerz wants to merge 1 commit intomainfrom
add-odf-to-rc-schedule
Open

Add ODF E2E job to RC nightly schedule#285
eliorerz wants to merge 1 commit intomainfrom
add-odf-to-rc-schedule

Conversation

@eliorerz
Copy link
Copy Markdown
Collaborator

@eliorerz eliorerz commented Apr 21, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced release candidate testing by adding coverage for additional storage configuration scenarios.

@github-actions github-actions Bot added the ci-cd CI/CD infrastructure label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2133cfe7-2332-4ff7-b515-d5d4ceb9701f

📥 Commits

Reviewing files that changed from the base of the PR and between 7d5248f and 8e282b9.

📒 Files selected for processing (1)
  • .github/workflows/e2e-deployment-rc.yml

Walkthrough

Modified a GitHub Actions workflow file to rename a step and add a new job. The existing step triggering LVMS end-to-end deployment was renamed for clarity, and a new job was added to trigger the same workflow with ODF storage plugin parameters for additional test coverage on the same runner configuration.

Changes

Cohort / File(s) Summary
E2E Deployment RC Workflow
.github/workflows/e2e-deployment-rc.yml
Renamed step "Trigger Workflow" to "Trigger E2E (LVMS)" in trigger-branch-workflow job. Added new trigger-odf-workflow job that invokes e2e-deployment.yml with ODF storage plugin configuration (run-disconnected=true, storage-plugin=odf) alongside existing LVMS-targeted job.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new ODF E2E workflow job to the RC nightly schedule, which is reflected in the addition of the trigger-odf-workflow job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-odf-to-rc-schedule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Tarball created: quay.io/edge-infrastructure/enclave:f2454889ebbfb66876494b51867c5ccd64b41c53 (f245488)

@maorfr
Copy link
Copy Markdown
Collaborator

maorfr commented Apr 22, 2026

would this work on 0-rc given #204 was only merged into main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants