start partner install conditionally only if file exists#29
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthroughbootstrap.sh now conditionally attempts Partner OverLay deployment: it prints a prompt, checks for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kbsingh
left a comment
There was a problem hiding this comment.
just two minor comments, looks good otherwise
| # | ||
| echo -p "Deploying Partner OverLay .. " -n1 -s | ||
| if [ -f ./partner-install/start.sh ]; then | ||
| ./partner-install/start.sh ${workingDir}/ocp-cluster/auth/kubeconfig ${global_vars} ${certs_vars} 2>&1 >> ${log} |
There was a problem hiding this comment.
is it worth checking the script is +x, or maybe force it with a /usr/bin/bash ?
There was a problem hiding this comment.
minor other point would be if the global_vars and certs_var's are absolute references (ie, consuming when needed the working_dir prefix )
There was a problem hiding this comment.
executing the script with bash. the absolute reference to vars i'll keep for a future PR.
9f3de34 to
15ab05a
Compare
related to https://github.com/gori-project/GoRI/issues/816
replaces #25
in this PR we uncomment the partner install start script execution and make the execution conditional only if the file exists. this will facilitate testing and production needs.
Summary by CodeRabbit