Skip to content

fix: deploy Cincinnati UpdateService to all clusters except local-cluster#545

Open
maorfr wants to merge 1 commit into
mainfrom
fix/cincinnati-deploy-all-clusters
Open

fix: deploy Cincinnati UpdateService to all clusters except local-cluster#545
maorfr wants to merge 1 commit into
mainfrom
fix/cincinnati-deploy-all-clusters

Conversation

@maorfr

@maorfr maorfr commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Changed Cincinnati UpdateService PlacementRule from clusterset-based selection to label-based selection
  • Now deploys to all managed clusters except local-cluster
  • Aligns with the pattern used in LVMS and ODF plugins

Changes

  • Modified operators/cincinnati-operator/tasks.yaml PlacementRule to use local-cluster: NotIn ["true"] selector instead of clusterset: In ["account", "default", "platform"]

Why

The previous clusterset-based approach limited UpdateService deployment to specific clustersets. The new approach ensures all managed clusters receive update service configuration regardless of their clusterset assignment.

Test Plan

  • Verify PlacementRule targets all managed clusters
  • Confirm local-cluster is excluded from placement
  • Check that UpdateService policy is applied to all spoke clusters

…ster

Changed PlacementRule from clusterset-based selection to label-based
selection that excludes local-cluster. This aligns with the pattern
used in LVMS and ODF plugins and ensures UpdateService deploys to
all managed clusters regardless of their clusterset assignment.

Assisted-by: Claude Code <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@maorfr, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1ad19742-34b0-45dc-8f43-b23fad851c03

📥 Commits

Reviewing files that changed from the base of the PR and between 5497289 and 8d0ad8a.

📒 Files selected for processing (1)
  • operators/cincinnati-operator/tasks.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cincinnati-deploy-all-clusters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the operators Operator installation/config label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

operators Operator installation/config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant