Skip to content

Make run_seed.sh work again#1001

Merged
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
omertuc:rseed
Mar 18, 2026
Merged

Make run_seed.sh work again#1001
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
omertuc:rseed

Conversation

@omertuc
Copy link
Copy Markdown
Member

@omertuc omertuc commented Jan 13, 2026

See commit message

Summary by CodeRabbit

  • Chores
    • Updated OpenShift release version to 4.22.0-ec.0.
    • Adjusted seed generation to change etcd defragmentation behavior (removed automated defrag flag).

@openshift-ci openshift-ci bot requested review from danmanor and tsorya January 13, 2026 12:22
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9656a74-3c70-4adb-a128-eae08b685324

📥 Commits

Reviewing files that changed from the base of the PR and between b0933d6 and 25ad620.

📒 Files selected for processing (1)
  • run_seed.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • run_seed.sh

Walkthrough

The run_seed.sh script's RELEASE_IMAGE was updated from 4.13.0-x86_64 to 4.22.0-ec.0-x86_64, and the --etcd-defrag flag was removed from the cargo run invocation.

Changes

Cohort / File(s) Summary
Seed script configuration
run_seed.sh
Updated RELEASE_IMAGE to 4.22.0-ec.0-x86_64; removed --etcd-defrag flag from the cargo run command.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main purpose of the pull request—fixing run_seed.sh to work again by resolving two specific issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

@danmanor
Copy link
Copy Markdown
Member

@omertuc What about the backup ? do we want to recreate the backup every time ?

@danmanor
Copy link
Copy Markdown
Member

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-aws-ovn-single-node-recert-parallel, ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Copy Markdown
Member

/override ci/prow/ibi-e2e-flow ci/prow/ibu-e2e-flow

@danmanor
Copy link
Copy Markdown
Member

/hold

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/ibi-e2e-flow, ci/prow/ibu-e2e-flow

Details

In response to this:

/override ci/prow/ibi-e2e-flow ci/prow/ibu-e2e-flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Copy Markdown
Member

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-aws-ovn-single-node-recert-parallel, ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 13, 2026

/retest

3 similar comments
@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 13, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 13, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 14, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 15, 2026

/unhold

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 15, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 16, 2026

/retest ibi-e2e-flow

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 16, 2026

/test ibi-e2e-flow

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 17, 2026

/override ?

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 17, 2026

@omertuc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/4.14-images
  • ci/prow/4.15-images
  • ci/prow/4.16-images
  • ci/prow/4.17-images
  • ci/prow/baremetalds-sno-recert-cluster-rename
  • ci/prow/cargo-check
  • ci/prow/cargo-clippy
  • ci/prow/cargo-test
  • ci/prow/e2e-aws-ovn-single-node-recert-parallel
  • ci/prow/e2e-aws-ovn-single-node-recert-serial
  • ci/prow/ibi-e2e-flow
  • ci/prow/ibu-e2e-flow
  • ci/prow/images
  • pull-ci-rh-ecosystem-edge-recert-main-4.14-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.15-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.16-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.17-images
  • pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-test
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
  • pull-ci-rh-ecosystem-edge-recert-main-ibi-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-ibu-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 18, 2026

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 18, 2026

@omertuc: Overrode contexts on behalf of omertuc: ci/prow/e2e-aws-ovn-single-node-recert-parallel

Details

In response to this:

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 18, 2026

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 18, 2026

@omertuc: Overrode contexts on behalf of omertuc: ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 19, 2026

/retest

1 similar comment
@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 19, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Jan 21, 2026

/test baremetalds-sno-recert-cluster-rename

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Feb 11, 2026

/retest

2 similar comments
@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Feb 12, 2026

/retest

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Feb 18, 2026

/retest

Fixes two issues with `run_seed.sh`:

- `etcd-defrag` doesn't work with extending expiration for some reason, so
it blocks us from running the script (this is probably a bug, should be
fixed separately)

- We should use newer etcd versions to support seed images coming from
  newer OpenShift releases.
@openshift-ci openshift-ci bot added the lgtm label Mar 18, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Mar 18, 2026

/override ?

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 18, 2026

@omertuc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/baremetalds-sno-recert-cluster-rename
  • ci/prow/cargo-check
  • ci/prow/cargo-clippy
  • ci/prow/cargo-test
  • ci/prow/e2e-aws-ovn-single-node-recert-parallel
  • ci/prow/e2e-aws-ovn-single-node-recert-serial
  • ci/prow/ibi-e2e-flow
  • ci/prow/ibu-e2e-flow
  • ci/prow/images
  • ci/prow/ipc-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-test
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
  • pull-ci-rh-ecosystem-edge-recert-main-ibi-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-ibu-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-images
  • pull-ci-rh-ecosystem-edge-recert-main-ipc-e2e-flow
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Copy Markdown
Member Author

omertuc commented Mar 18, 2026

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 18, 2026

@omertuc: Overrode contexts on behalf of omertuc: ci/prow/e2e-aws-ovn-single-node-recert-parallel

Details

In response to this:

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3f69674 into rh-ecosystem-edge:main Mar 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants