Skip to content

Update on-cel-expression values for tekton pipelines to limit unnecessary builds #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fontivan merged 1 commit into from
May 5, 2025
Merged

Update on-cel-expression values for tekton pipelines to limit unnecessary builds #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .tekton/recert-4-20-pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,28 @@ metadata:
build.appstudio.redhat.com/target_branch: '{{target_branch}}'
pipelinesascode.tekton.dev/cancel-in-progress: "true"
pipelinesascode.tekton.dev/max-keep-runs: "3"
pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch == "main"
pipelinesascode.tekton.dev/on-cel-expression: |
event == "pull_request" &&
target_branch == "main" &&
(
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/***'.pathChanged() ||
'hack/***'.pathChanged() ||
'ouger/***'.pathChanged() ||
'src/***'.pathChanged() ||
'vendor/***'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-pull-request.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/***'.pathChanged() ||
'.konflux/lock-runtime/***'.pathChanged()
Comment on lines +15 to +31
Copy link
Copy Markdown

@coderabbitai coderabbitai bot May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Fix wildcard patterns in .pathChanged() calls.
The use of *** may not match any files. Tekton’s globbing expects ** for recursive matching. Incorrect patterns can silently disable triggers for those directories.

-        'etcddump/***'.pathChanged() ||
+        'etcddump/**'.pathChanged() ||
-        'hack/***'.pathChanged() ||
+        'hack/**'.pathChanged() ||
-        'ouger/***'.pathChanged() ||
+        'ouger/**'.pathChanged() ||
-        'src/***'.pathChanged() ||
+        'src/**'.pathChanged() ||
-        'vendor/***'.pathChanged() ||
+        'vendor/**'.pathChanged() ||
-        '.konflux/lock-build/***'.pathChanged() ||
+        '.konflux/lock-build/**'.pathChanged() ||
-        '.konflux/lock-runtime/***'.pathChanged()
+        '.konflux/lock-runtime/**'.pathChanged()
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/***'.pathChanged() ||
'hack/***'.pathChanged() ||
'ouger/***'.pathChanged() ||
'src/***'.pathChanged() ||
'vendor/***'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-pull-request.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/***'.pathChanged() ||
'.konflux/lock-runtime/***'.pathChanged()
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/**'.pathChanged() ||
'hack/**'.pathChanged() ||
'ouger/**'.pathChanged() ||
'src/**'.pathChanged() ||
'vendor/**'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-pull-request.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/**'.pathChanged() ||
'.konflux/lock-runtime/**'.pathChanged()
🧰 Tools
🪛 YAMLlint (1.35.1)

[error] 29-29: trailing spaces

(trailing-spaces)

)
creationTimestamp: null
labels:
appstudio.openshift.io/application: lifecycle-agent-4-20
Expand Down
23 changes: 22 additions & 1 deletion .tekton/recert-4-20-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,28 @@ metadata:
build.appstudio.redhat.com/target_branch: '{{target_branch}}'
pipelinesascode.tekton.dev/cancel-in-progress: "false"
pipelinesascode.tekton.dev/max-keep-runs: "3"
pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && files.all != ["konflux_clusterserviceversion_overlay.data"]
pipelinesascode.tekton.dev/on-cel-expression: |
event == "push" &&
target_branch == "main" &&
(
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/***'.pathChanged() ||
'hack/***'.pathChanged() ||
'ouger/***'.pathChanged() ||
'src/***'.pathChanged() ||
'vendor/***'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-push.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/***'.pathChanged() ||
'.konflux/lock-runtime/***'.pathChanged()
Comment on lines +15 to +31
Copy link
Copy Markdown

@coderabbitai coderabbitai bot May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Correct wildcard syntax in .pathChanged() patterns.
The patterns currently use triple asterisks (***), which may not be recognized by Tekton’s glob matching. Standard recursive globs use double asterisks (**). If unsupported, these conditions will never evaluate to true, defeating the purpose of fine-grained triggers.

Apply this diff to fix the patterns:

-        'etcddump/***'.pathChanged() ||
+        'etcddump/**'.pathChanged() ||
-        'hack/***'.pathChanged() ||
+        'hack/**'.pathChanged() ||
-        'ouger/***'.pathChanged() ||
+        'ouger/**'.pathChanged() ||
-        'src/***'.pathChanged() ||
+        'src/**'.pathChanged() ||
-        'vendor/***'.pathChanged() ||
+        'vendor/**'.pathChanged() ||
-        '.konflux/lock-build/***'.pathChanged() ||
+        '.konflux/lock-build/**'.pathChanged() ||
-        '.konflux/lock-runtime/***'.pathChanged()
+        '.konflux/lock-runtime/**'.pathChanged()
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/***'.pathChanged() ||
'hack/***'.pathChanged() ||
'ouger/***'.pathChanged() ||
'src/***'.pathChanged() ||
'vendor/***'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-push.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/***'.pathChanged() ||
'.konflux/lock-runtime/***'.pathChanged()
'.tekton/build-pipeline.yaml'.pathChanged() ||
'etcddump/**'.pathChanged() ||
'hack/**'.pathChanged() ||
'ouger/**'.pathChanged() ||
'src/**'.pathChanged() ||
'vendor/**'.pathChanged() ||
'build.rs'.pathChanged() ||
'Cargo.lock'.pathChanged() ||
'Cargo.toml'.pathChanged() ||
'ownership.sh'.pathChanged() ||
'reproto'.pathChanged() ||
'run_seed'.pathChanged() ||
'vendor.sh'.pathChanged() ||
'.tekton/recert-4-20-push.yaml'.pathChanged() ||
'.konflux/Dockerfile'.pathChanged() ||
'.konflux/lock-build/**'.pathChanged() ||
'.konflux/lock-runtime/**'.pathChanged()
🧰 Tools
🪛 YAMLlint (1.35.1)

[error] 29-29: trailing spaces

(trailing-spaces)

)
creationTimestamp: null
labels:
appstudio.openshift.io/application: lifecycle-agent-4-20
Expand Down