Skip to content

Update renovate.json configuration#290

Merged
fontivan merged 1 commit intorh-ecosystem-edge:mainfrom
fontivan:sskeard/update-renovate
May 27, 2025
Merged

Update renovate.json configuration#290
fontivan merged 1 commit intorh-ecosystem-edge:mainfrom
fontivan:sskeard/update-renovate

Conversation

@fontivan
Copy link
Copy Markdown
Member

@fontivan fontivan commented May 26, 2025

Summary by CodeRabbit

  • Chores
    • Updated automated dependency management settings to add labels and refine update rules for specific configuration paths, enhancing PR labeling and control over update types.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 26, 2025

Walkthrough

The Renovate configuration file was updated to introduce automated labeling and restrict automerge rules to digest update types for PRs affecting .konflux/** and .tekton/** paths. These changes add label assignment and update type filtering to the custom regex manager and Tekton configuration package rules.

Changes

File(s) Change Summary
renovate.json Added addLabels and matchUpdateTypes: ["digest"] to custom regex manager and Tekton rules.

Possibly related PRs

  • Update renovate.json configuration #240: Modifies the renovate.json configuration, specifically the custom regex manager rules for .konflux/** paths, similar to the label management and update type filtering in this PR.

Suggested reviewers

  • mresvanis
  • tsorya

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e01b3e9 and e962e88.

📒 Files selected for processing (1)
  • renovate.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (2)
renovate.json (2)

23-27: Add automated labeling and restrict Konflux regex manager to digest updates
The new addLabels field will tag all custom regex PRs under .konflux/** with approved and lgtm, and matchUpdateTypes: ["digest"] scopes auto-approvals and merges to only digest updates. Moving includePaths above matchManagers is purely cosmetic (JSON ordering is irrelevant).

Also applies to: 31-34, 37-39


57-67:

Details

❓ Verification inconclusive

Scope Tekton labels to digest updates only (verify automerge behavior)
You've added a nested packageRules under tekton to apply labels only on digest updates, but note that the top-level tekton config still has autoApprove and automerge: true, so non-digest updates will continue to auto-approve & merge. If the goal is to limit auto-merge to digest updates, move autoApprove and automerge into this rule or add a manager-level matchUpdateTypes: ["digest"]. Also confirm that nested packageRules under the tekton manager config is supported by your Renovate version; if not, migrate it to the top-level packageRules.


I’d like to confirm how the tekton block is structured and whether autoApprove/automerge live at the top level or within that block. Let’s extract the relevant sections:


🏁 Script executed:

#!/bin/bash
echo "== Tekton block =="
rg -C3 '"tekton"' -n renovate.json || true

echo
echo "== autoApprove settings =="
rg -C2 '"autoApprove"' -n renovate.json || true

echo
echo "== automerge settings =="
rg -C2 '"automerge"' -n renovate.json || true

Length of output: 1090


Let’s locate all packageRules occurrences to see where your digest-specific rule lives:


🏁 Script executed:

#!/bin/bash
echo "== All packageRules occurrences =="
rg -C5 '"packageRules"' -n renovate.json || true

Length of output: 631


Scope Tekton auto-merge to digest updates only (verify nested packageRules support)

Your current tekton manager block (renovate.json:45–48) enables auto-approval and automerge for all Tekton updates, but your nested digest rule (renovate.json:57–67) only adds labels for digest updates. As a result, non-digest updates will still auto-approve & merge under the top-level settings.

To limit auto-merge to digest updates:

  • Either move autoApprove and automerge into the digest-specific rule under tekton.packageRules,
  • Or add "matchUpdateTypes": ["digest"] at the manager level alongside autoApprove/automerge.

Also confirm that your Renovate version supports nesting packageRules inside a manager block; if not, migrate this rule into the top-level packageRules array.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested review from mresvanis and omertuc May 26, 2025 14:57
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fontivan
Once this PR has been reviewed and has the lgtm label, please assign mresvanis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fontivan
Copy link
Copy Markdown
Member Author

/hold

@fontivan
Copy link
Copy Markdown
Member Author

/cc @rauhersu

@openshift-ci openshift-ci bot requested a review from rauhersu May 26, 2025 15:09
@fontivan
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented May 26, 2025

@fontivan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-recert-serial e962e88 link true /test e2e-aws-ovn-single-node-recert-serial
ci/prow/e2e-aws-ovn-single-node-recert-parallel e962e88 link true /test e2e-aws-ovn-single-node-recert-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fontivan fontivan merged commit a13cdec into rh-ecosystem-edge:main May 27, 2025
11 of 14 checks passed
@fontivan fontivan deleted the sskeard/update-renovate branch May 27, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant