Pin rust version to prevent unexpected breakages due to rust changes by fontivan · Pull Request #332 · rh-ecosystem-edge/recert

fontivan · 2025-06-20T15:14:19Z

For now, we can pin to 1.87
This can be updated semi regularly to keep pace with new rust features

Summary by CodeRabbit

Chores
- Updated the Docker build process to use Rust version 1.87 for improved alignment with the production environment.
- Added documentation within the Dockerfile to clarify the chosen Rust version.
- Specified a minimum Rust compiler version requirement (1.75) to ensure compatibility with the target environment.

coderabbitai · 2025-06-20T15:14:25Z

Walkthrough

The Dockerfile was updated to change the Rust base image from a generic version (rust:1) to a specific version (rust:1.87). A comment was added above this line explaining that the Rust version is pinned to prevent unexpected breakages due to Rust changes. Additionally, the Cargo.toml file was modified to specify a minimum Rust compiler version (rust-version = "1.75"). No other modifications were made.

Changes

File	Change Summary
Dockerfile	Changed Rust base image from `rust:1` to `rust:1.87` and added a comment explaining the pinning.
Cargo.toml	Added `rust-version = "1.75"` under `[package]` to specify the minimum Rust compiler version required for the project.

Suggested labels

lgtm, approved

Suggested reviewers

omertuc

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 511e58f and c6f3bec.

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Cargo.toml

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Red Hat Konflux / recert-4-20-on-pull-request
GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dockerfile (1)

2-2: Consider pinning the base image by digest for immutability

Using a digest (e.g., rust:1.75@sha256:<digest>) prevents unexpected updates if the 1.75 tag is repointed upstream.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ddc59c and 747c2f1.

📒 Files selected for processing (1)

Dockerfile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (1)

Dockerfile (1)

1-2: Pin Rust version to 1.75 for RHEL9 compatibility — Approved

The added comment and explicit rust:1.75 tag align with the PR goal of matching RHEL9’s Rust version.

fontivan · 2025-06-20T15:22:41Z

/cc @omertuc @mresvanis

fontivan · 2025-06-20T18:41:29Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-06-20T18:41:32Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T18:41:32Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-06-20T18:41:35Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T18:41:36Z

/cherry-pick release-4.17

openshift-cherrypick-robot · 2025-06-20T18:41:38Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T18:41:40Z

/cherry-pick release-4.16

openshift-cherrypick-robot · 2025-06-20T18:41:42Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T19:15:46Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2025-06-20T19:15:49Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T19:15:50Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2025-06-20T19:15:53Z

@fontivan: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-20T21:06:40Z

/retest

fontivan · 2025-06-21T02:57:28Z

/retest

fontivan · 2025-06-23T12:11:08Z

/retest

- For now, we can pin to 1.87 - This can be updated semi regularly to keep pace with new rust features

- We need to use a version that is compatible with the rust version available in rhel9 - rhel9 currently ships rust 1.75 - Regenerated lockfile to make sure it is also compatible with the specified rust-version - For more information, refer to: - https://doc.rust-lang.org/cargo/reference/rust-version.html - rust-lang/cargo#12861 - rust-lang/cargo#13503

omertuc · 2025-06-24T08:36:35Z

/lgtm

omertuc · 2025-06-24T08:36:39Z

/approve

openshift-ci · 2025-06-24T10:49:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [omertuc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fontivan · 2025-06-24T11:29:30Z

/retest-required

openshift-ci · 2025-06-24T14:07:02Z

@fontivan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-recert-parallel	`c6f3bec`	link	true	`/test e2e-aws-ovn-single-node-recert-parallel`
ci/prow/e2e-aws-ovn-single-node-recert-serial	`c6f3bec`	link	true	`/test e2e-aws-ovn-single-node-recert-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

omertuc · 2025-06-24T15:04:33Z

/retest

fontivan · 2025-06-24T15:19:43Z

/override

openshift-ci · 2025-06-24T15:19:45Z

@fontivan: /override requires failed status contexts to operate on, but none was given

Details

In response to this:

/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-24T15:20:02Z

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel

openshift-ci · 2025-06-24T15:20:07Z

@fontivan: fontivan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fontivan · 2025-06-24T15:20:22Z

/override ci/prow/e2e-aws-ovn-single-node-recert-serial

openshift-ci · 2025-06-24T15:20:28Z

@fontivan: fontivan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:21:17Z

@fontivan: new pull request created: #345

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:21:54Z

@fontivan: new pull request created: #346

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:22:33Z

@fontivan: new pull request created: #347

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:23:11Z

@fontivan: new pull request created: #348

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:23:49Z

@fontivan: new pull request created: #349

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-06-24T15:24:26Z

@fontivan: #332 failed to apply on top of branch "release-4.14":

Applying: Pin rust version to prevent unexpected breakages due to rust changes - For now, we can pin to 1.87 - This can be updated semi regularly to keep pace with new rust features
Using index info to reconstruct a base tree...
M	Dockerfile
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Specify rust-version in Cargo.toml - We need to use a version that is compatible with the rust version available in rhel9 - rhel9 currently ships rust 1.75 - Regenerated lockfile to make sure it is also compatible with the specified rust-version - For more information, refer to: - https://doc.rust-lang.org/cargo/reference/rust-version.html - https://github.com/rust-lang/cargo/pull/12861 - https://github.com/rust-lang/cargo/issues/13503
Using index info to reconstruct a base tree...
M	Cargo.toml
Falling back to patching base and 3-way merge...
Auto-merging Cargo.toml
CONFLICT (content): Merge conflict in Cargo.toml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Specify rust-version in Cargo.toml - We need to use a version that is compatible with the rust version available in rhel9 - rhel9 currently ships rust 1.75 - Regenerated lockfile to make sure it is also compatible with the specified rust-version - For more information, refer to: - https://doc.rust-lang.org/cargo/reference/rust-version.html - https://github.com/rust-lang/cargo/pull/12861 - https://github.com/rust-lang/cargo/issues/13503

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from rauhersu and tsorya June 20, 2025 15:14

coderabbitai bot reviewed Jun 20, 2025

View reviewed changes

openshift-ci bot requested review from mresvanis and omertuc June 20, 2025 15:22

fontivan force-pushed the sskeard/konflux-backport-4-20 branch from 6f6df7e to 0170df9 Compare June 20, 2025 17:37

fontivan changed the title ~~Pin rust version to the version available in rhel9~~ Pin rust version to prevent unexpected breakages due to rust changes Jun 20, 2025

fontivan force-pushed the sskeard/konflux-backport-4-20 branch from 0170df9 to 9fa2fdb Compare June 20, 2025 18:27

fontivan added 2 commits June 23, 2025 15:17

Pin rust version to prevent unexpected breakages due to rust changes

ae3f8a6

- For now, we can pin to 1.87 - This can be updated semi regularly to keep pace with new rust features

fontivan force-pushed the sskeard/konflux-backport-4-20 branch from 9fa2fdb to 511e58f Compare June 23, 2025 19:18

omertuc reviewed Jun 23, 2025

View reviewed changes

Comment thread Cargo.toml

Update rust-version comment to be more descriptive

c6f3bec

openshift-ci bot assigned omertuc Jun 24, 2025

openshift-ci bot added the lgtm label Jun 24, 2025

openshift-ci bot added the approved label Jun 24, 2025

fontivan merged commit 258700f into rh-ecosystem-edge:main Jun 24, 2025
14 of 17 checks passed

openshift-cherrypick-robot mentioned this pull request Jun 24, 2025

[release-4.19] Pin rust version to prevent unexpected breakages due to rust changes #345

Merged

openshift-cherrypick-robot mentioned this pull request Jun 24, 2025

[release-4.18] Pin rust version to prevent unexpected breakages due to rust changes #346

Merged

openshift-cherrypick-robot mentioned this pull request Jun 24, 2025

[release-4.17] Pin rust version to prevent unexpected breakages due to rust changes #347

Merged

openshift-cherrypick-robot mentioned this pull request Jun 24, 2025

[release-4.16] Pin rust version to prevent unexpected breakages due to rust changes #348

Merged

openshift-cherrypick-robot mentioned this pull request Jun 24, 2025

[release-4.15] Pin rust version to prevent unexpected breakages due to rust changes #349

Merged

Conversation

fontivan commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 20, 2025

Uh oh!

fontivan commented Jun 20, 2025

Uh oh!

fontivan commented Jun 21, 2025

Uh oh!

fontivan commented Jun 23, 2025

Uh oh!

Uh oh!

omertuc commented Jun 24, 2025

Uh oh!

omertuc commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

fontivan commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

omertuc commented Jun 24, 2025

Uh oh!

fontivan commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

fontivan commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

fontivan commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

Uh oh!

fontivan commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)