Skip to content

CNF-20721: Fix spurious quotes around CPE label#869

Merged
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
fontivan:sskeard/konflux-backport-4-21
Dec 5, 2025
Merged

CNF-20721: Fix spurious quotes around CPE label#869
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
fontivan:sskeard/konflux-backport-4-21

Conversation

@fontivan
Copy link
Copy Markdown
Member

@fontivan fontivan commented Dec 2, 2025

  • We should not use additional quotes when adding labels in the .tekton yaml files
  • This causes additional escaped quotes to be incorrectly added to the strings

Summary by CodeRabbit

  • Chores
    • Updated internal build pipeline configuration formatting.

Note: This release contains infrastructure updates with no user-visible changes.

✏️ Tip: You can customize this high-level summary in your review settings.

- We should not use additional quotes when adding labels in the .tekton yaml files
- This causes additional escaped quotes to be incorrectly added to the strings
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Dec 2, 2025

@fontivan: This pull request references CNF-20721 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • We should not use additional quotes when adding labels in the .tekton yaml files
  • This causes additional escaped quotes to be incorrectly added to the strings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from omertuc and tsorya December 2, 2025 19:03
@openshift-ci openshift-ci bot added the approved label Dec 2, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 2, 2025

Walkthrough

Removed unnecessary quotes from the CPE label value in the Tekton build pipeline YAML, changing the format from an escaped string literal to an unquoted plain value. This is a formatting correction with no behavioral impact.

Changes

Cohort / File(s) Change Summary
YAML Formatting Fix
\.tekton/build-pipeline\.yaml
Removed unnecessary quotes from the CPE label value (cpe="cpe:/a:redhat:openshift:4.21::el9"cpe=cpe:/a:redhat:openshift:4.21::el9)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • omertuc
  • danmanor

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing escaped quotes around a CPE label value in the build pipeline YAML configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec0697c and d7f7c55.

📒 Files selected for processing (1)
  • .tekton/build-pipeline.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Red Hat Konflux / recert-4-21-on-pull-request
  • GitHub Check: build
🔇 Additional comments (1)
.tekton/build-pipeline.yaml (1)

263-263: Correct: Removes spurious quotes from CPE label value.

The change removes the unnecessary quotes that were causing the label to be set with literal escaped quotes included in the value. This aligns the CPE label with the pattern used by all other labels in the LABELS list (e.g., com.redhat.component=recert, distribution-scope=public), ensuring consistent formatting and correct label values.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Dec 2, 2025

@fontivan: This pull request references CNF-20721 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • We should not use additional quotes when adding labels in the .tekton yaml files
  • This causes additional escaped quotes to be incorrectly added to the strings

Summary by CodeRabbit

  • Chores
  • Updated internal build pipeline configuration formatting.

Note: This release contains infrastructure updates with no user-visible changes.

✏️ Tip: You can customize this high-level summary in your review settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fontivan
Copy link
Copy Markdown
Member Author

fontivan commented Dec 5, 2025

/cc @rauhersu @by2waysprojects @omertuc

@openshift-ci openshift-ci bot requested a review from rauhersu December 5, 2025 13:53
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Dec 5, 2025

@fontivan: GitHub didn't allow me to request PR reviews from the following users: by2waysprojects.

Note that only rh-ecosystem-edge members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @rauhersu @by2waysprojects @omertuc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rauhersu
Copy link
Copy Markdown
Collaborator

rauhersu commented Dec 5, 2025

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan, rauhersu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a30da73 into rh-ecosystem-edge:main Dec 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants