This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Move use-patternfly components and hooks in appservice-patternfly #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes script used by the example apps
This adds Storybook to the workspace to act as the single documentation point for all packages. It's using a beta version of Storybook that makes this kind of usage possible, together with zero-conf Typescript support.
dlabaj
reviewed
Jul 20, 2020
Member
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Looks great @riccardo-forina Just a few comments and questions.
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2020 Riccardo Forina | |||
Member
There was a problem hiding this comment.
Can we change copy right to redhat?
| @@ -0,0 +1,167 @@ | |||
| # TSDX React User Guide | |||
Member
There was a problem hiding this comment.
TSDX looks cool. Guessing we want to standardize on this instead of webpack configs for the libraries.
|
|
||
| ## Commands | ||
|
|
||
| TSDX scaffolds your new library inside `/src`, and also sets up a [Parcel-based](https://parceljs.org) playground for it inside `/example`. |
Member
There was a problem hiding this comment.
Probably want to update this readme to be specific to app-layout library.
| "@patternfly/react-core": "^3.77.2", | ||
| "@patternfly/react-icons": "^3.10.15", | ||
| "@patternfly/react-styles": "^3.5.7", | ||
| "react": ">=16", |
Member
There was a problem hiding this comment.
We probably want to use the version where hooks are added, and have a specific version for these libraries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
This is a WIP, I'll document the changes I did to the monorepo later.