Fix contrast issue in code blocks on light mode#511
Merged
rhazdon merged 1 commit intorhazdon:masterfrom Nov 17, 2025
Merged
Conversation
This uses the child combinator selector > to make sure the `pre > code` block doesn't override the top-level `code` block unintentionally. Closes rhazdon#364
herzenschein
force-pushed
the
contrast-fix
branch
from
73424e1 to
2659ba1
Compare
thgoebel
added a commit
to thgoebel/hugo-theme-hello-friend-ng
that referenced
this pull request
Mar 27, 2026
This partially reverts rhazdon#511. Reason: these two selectors are broken. The first, because a CSS child selector at the top-level, without a parent, has no meaning. The second, because hugo emits `<code>` so we need an element selector. The class selector would match `<div class="code">`.
thgoebel
added a commit
to thgoebel/hugo-theme-hello-friend-ng
that referenced
this pull request
Mar 27, 2026
This is a follow-up to rhazdon#511, as an alternative fix for rhazdon#364. Note: this only applies to plain multi-line code blocks. Multi-line code blocks highlighted by PrismJS still look weird.
|
This PR does three things:
I came across this PR because I think it is causing #527. See that ticket for more details. I am proposing an alternative in #529. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the child combinator selector > to make sure the
pre > codeblock doesn't override the top-levelcodeblock unintentionally.Closes #364.