efisecdb: Fix default hash and help output#299
Open
vathpela wants to merge 2 commits into
Open
Conversation
When we run `efisecdb -t help` it says:
$ efisecdb -t help
Supported hashes: sha512 sha384 sha256 sha1
Default hash is sha256
But in practice we see:
$ efisecdb -o dbx.bin -a -g {empty} -h e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
efisecdb: hash type is not set
This changes it so we actually default to sha256.
Signed-off-by: Peter Jones <pjones@redhat.com>
While it's nice to support SHA-1 so we can e.g. build test databases that look like that one insane vendor's 'db', there's no reason to advertise this and encourage people to do it. This patch makes it so "efisecdb -t help" doesn't show that we support SHA-1. Signed-off-by: Peter Jones <pjones@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch series does two things: