Simplify image extraction logic in mcp-container-testing - #14
Merged
Conversation
samdoran
requested changes
Jul 20, 2026
Member
There was a problem hiding this comment.
I tried several ways to get rid of the need for the extract-server-image task entirely. Unfortunately that's not possible because the parameters for the sidecars for the mcp-protocol-audit task need to be computed beforehand. 😞
At least the extract-server-image task can be simplified a little bit more and we can get rid of some unnecessary params.
There are some good examples on how to use the snapshot data in the docs on custom integration tests.
samdoran
approved these changes
Jul 21, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.