Skip to content

kstests: add updates.img support to settings #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rvykydal wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

kstests: add updates.img support to settings #59

rvykydal wants to merge 1 commit into from

Conversation

@rvykydal
Copy link
Collaborator

@rvykydal rvykydal commented Jan 4, 2023

No description provided.

@rvykydal rvykydal requested a review from velezd January 5, 2023 08:08
VladimirSlavik
VladimirSlavik approved these changes Jan 5, 2023
View reviewed changes
Copy link

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@velezd
Copy link
Collaborator

velezd commented Jan 6, 2023

Why settings, what is the updates.img going to be used for?

@rvykydal
Copy link
Collaborator Author

rvykydal commented Jan 9, 2023

Why settings, what is the updates.img going to be used for?

The expected usage for now is testing of updates containing other changes than a PR of Anaconda (ie testing of updates of other packages).
I was considering also passing via event as the updates.img is (in most cases) relative to the tested boot.iso / compose. I went for the settings for a start as I didn't want to expose it much.

@rvykydal rvykydal marked this pull request as draft January 10, 2023 08:55
jkonecny12
jkonecny12 reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. However, I would rather avoid having the links here.

tests/test_library/kickstart-test/test-settings.ini
kstest_repo=https://github.com/rhinstaller/kickstart-tests.git
kstest_repo_branch=master
kstest_local_repo=/var/tmp/kickstart-tests
kstest_updates_image=http://cobra02/users/rv/updates.getmac.img
Copy link
Member

@jkonecny12 jkonecny12 Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link shouldn't be here.

@rvykydal
Copy link
Collaborator Author

rvykydal commented Jan 25, 2023

After discussion with @velezd I am going to use event structure (in a separate plugin?) instead of a setting for updates image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkonecny12 jkonecny12 jkonecny12 left review comments

@velezd velezd Awaiting requested review from velezd

+1 more reviewer

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvykydal @velezd @jkonecny12 @VladimirSlavik