Update riak-client dependency to 1.4 #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is to allow ripple users to useadhoc erlang fns (see basho/riak-ruby-client@1023ec1)
This update passes all existing specs. Given that this is not a change to expose new functionality for Ripple itself, but rather to allow the outside application to use an updated gem, I was unclear on any appropriate new specs.
I looked at the changes between Riak-client 1.1 and 1.4.0 and all API changes appear to be additions of new functions or new optional parameters, so it seems like the interface Ripple uses has not changed, and the specs appear to confirm that.