Fix for theme_ui_submit html generation#12
Open
michael131468 wants to merge 4 commits intoriccardonobile:testingfrom
Open
Fix for theme_ui_submit html generation#12michael131468 wants to merge 4 commits intoriccardonobile:testingfrom
michael131468 wants to merge 4 commits intoriccardonobile:testingfrom
Conversation
…king a buttons value field with doubled up html of the button
…expected in the webmin ui-lib api
…pected in the webmin ui-lib api
… expected in the webmin ui-lib api
Author
|
Make theme_ui_columns_start/row/header make use of the tdtags argument as expected to in the webmin ui-lib api. This can be useful for things such as specifying colspan while generating tables. |
Owner
|
Thanks for the corrections :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button html was being doubled up because of a misplaced dot instead of semicolumn when generating the button value field. Was not a visible bug in terms of browser viewing, but was visible from html. This commit changes the dot to a semicolumn to fix it.