Fix cds() ignoring its length parameter#24
Merged
Conversation
The loop condition was hardcoded as `while i < 20` instead of `while i < length`, so cds() always produced a 20-codon sequence regardless of the argument passed. Adds a regression test covering multiple lengths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23.
cds()had a hardcodedwhile i < 20:loop condition instead ofwhile i < length:, so thelengthparameter was silently ignored and the method always returned a 20-codon sequence.test_cds_respects_length) that verifies the output length is correct for several different input values (5, 10, 50).Test plan
test_cds_respects_lengthfails before the fix and passes aftertest_cdscontinues to pass (no regression)poetry run python -m pytest faker_biology/tests🤖 Generated with Claude Code