Fix IndexError in protein_name_desc() due to off-by-one#25
Merged
Conversation
random.randint(a, b) is inclusive on both ends, so using len(protein_names) as the upper bound could return an index equal to the list length, causing an IndexError. Fixed by using len() - 1. Adds a regression test that calls protein_name_desc() 1000 times to reliably expose the error before the fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22.
random.randint(a, b)is inclusive on both ends. Usinglen(protein_names)as the upper bound means it can return an index equal to the list length, which is out of range and raises anIndexError.Fixed by changing:
to:
Test plan
test_protein_name_desc_no_index_errorcalls the method 1000 times — fails before fix, passes afterpoetry run python -m pytest faker_biology/tests🤖 Generated with Claude Code