Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the roy optimization last week, I have created a wasm implementation of roy. This PR might be a useful jumping off point for a conversation with most of the work done in
pronom_byte_array_helpers.go. In the WASM file we're now able to create a signature file at runtime using embedded defaults. These can also be updated more easily in the future.I looked at removing the static package and see it's used by
github.com/richardlehane/siegfried/pkg/libbut maybe there's another way of improving that API with updated roy work?Let me know what might need changing, e.g. maybe some of the light duplication in
pronom_byte_array_helpers.gocan better be done in the existingpronom.gofunctions?No rush on my end, I have to move focus onto the workshop this proof of concept is for but will try following up on anything asap.
TODO