Skip to content

Fix test failures: GoRouter context error and bottom action bar overflow - #203

Merged
richardthe3rd merged 2 commits into
claude/implement-my-festival-3diaOfrom
copilot/sub-pr-200
Jan 2, 2026
Merged

Fix test failures: GoRouter context error and bottom action bar overflow#203
richardthe3rd merged 2 commits into
claude/implement-my-festival-3diaOfrom
copilot/sub-pr-200

Conversation

Copilot AI commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Tests were failing due to GoRouter.of(context) being called in a test environment without a router, and the new My Festival action buttons causing a 85px overflow in the bottom action bar.

GoRouter Context Handling

Changed _handlePostInitRedirect() in lib/main.dart to use GoRouter.maybeOf() and return early when no router is available (e.g., in test environments):

final router = GoRouter.maybeOf(context);
if (router == null) {
  return;
}

Bottom Action Bar Layout

  • Wrapped actions in Expanded widgets to distribute horizontal space evenly
  • Added text overflow handling to ActionButton labels (overflow: TextOverflow.ellipsis, maxLines: 1)
  • Updated golden files for screenshot tests to reflect the constrained layout

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tion bar overflow

Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement My Festival favourites feature Fix test failures: GoRouter context error and bottom action bar overflow Jan 2, 2026
Copilot AI requested a review from richardthe3rd January 2, 2026 22:03
@richardthe3rd
richardthe3rd marked this pull request as ready for review January 2, 2026 22:03
@richardthe3rd
richardthe3rd merged commit bfad100 into claude/implement-my-festival-3diaO Jan 2, 2026
@richardthe3rd
richardthe3rd deleted the copilot/sub-pr-200 branch January 2, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants