Fix test failures: GoRouter context error and bottom action bar overflow - #203
Merged
richardthe3rd merged 2 commits intoJan 2, 2026
Merged
Conversation
…tion bar overflow Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement My Festival favourites feature
Fix test failures: GoRouter context error and bottom action bar overflow
Jan 2, 2026
richardthe3rd
marked this pull request as ready for review
January 2, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing due to
GoRouter.of(context)being called in a test environment without a router, and the new My Festival action buttons causing a 85px overflow in the bottom action bar.GoRouter Context Handling
Changed
_handlePostInitRedirect()inlib/main.dartto useGoRouter.maybeOf()and return early when no router is available (e.g., in test environments):Bottom Action Bar Layout
Expandedwidgets to distribute horizontal space evenlyActionButtonlabels (overflow: TextOverflow.ellipsis,maxLines: 1)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.