Skip to content

Apply review feedback: use npm ci and remove redundant festivals.json copy - #213

Merged
richardthe3rd merged 2 commits into
claude/cloudflare-workers-testing-ZSpKLfrom
copilot/sub-pr-212
Feb 8, 2026
Merged

Apply review feedback: use npm ci and remove redundant festivals.json copy#213
richardthe3rd merged 2 commits into
claude/cloudflare-workers-testing-ZSpKLfrom
copilot/sub-pr-212

Conversation

Copilot AI commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Addresses two review comments from PR #212 on Worker test infrastructure.

Changes:

  • mise.toml: Use npm ci instead of npm install in test:worker task to enforce lockfile-based installs and prevent non-deterministic dependency updates
  • .github/workflows/deploy-worker.yml: Remove redundant cp data/festivals.json step—already handled by npm pretest script in package.json

Before:

[tasks."test:worker"]
run = 'npm install && npm test'

After:

[tasks."test:worker"]
run = 'npm ci && npm test'

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

… copy

Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit tests for Cloudflare Worker (Phase 0) Apply review feedback: use npm ci and remove redundant festivals.json copy Feb 8, 2026
Copilot AI requested a review from richardthe3rd February 8, 2026 20:49
@richardthe3rd
richardthe3rd marked this pull request as ready for review February 8, 2026 21:57
@richardthe3rd
richardthe3rd merged commit e1952a8 into claude/cloudflare-workers-testing-ZSpKL Feb 8, 2026
1 check passed
@richardthe3rd
richardthe3rd deleted the copilot/sub-pr-212 branch February 8, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants