Apply review feedback: use npm ci and remove redundant festivals.json copy - #213
Merged
richardthe3rd merged 2 commits intoFeb 8, 2026
Merged
Conversation
… copy Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests for Cloudflare Worker (Phase 0)
Apply review feedback: use npm ci and remove redundant festivals.json copy
Feb 8, 2026
richardthe3rd
marked this pull request as ready for review
February 8, 2026 21:57
richardthe3rd
merged commit Feb 8, 2026
e1952a8
into
claude/cloudflare-workers-testing-ZSpKL
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review comments from PR #212 on Worker test infrastructure.
Changes:
npm ciinstead ofnpm installintest:workertask to enforce lockfile-based installs and prevent non-deterministic dependency updatescp data/festivals.jsonstep—already handled by npm pretest script in package.jsonBefore:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.