feat: enhancing contrast in light mode - #244
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/richardthe3rd/cambridge-beer-festival-app/sessions/b6e5c2a9-b5eb-4b2a-8224-4fc8c8749d48 Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
richardthe3rd
May 10, 2026 14:08
View session
richardthe3rd
marked this pull request as ready for review
May 10, 2026 14:08
Agent-Logs-Url: https://github.com/richardthe3rd/cambridge-beer-festival-app/sessions/7787aa24-0549-44f8-819f-6d611d269672 Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/richardthe3rd/cambridge-beer-festival-app/sessions/7787aa24-0549-44f8-819f-6d611d269672 Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/richardthe3rd/cambridge-beer-festival-app/sessions/7787aa24-0549-44f8-819f-6d611d269672 Co-authored-by: richardthe3rd <573334+richardthe3rd@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves perceived contrast in light mode by adjusting several UI element colors (menu items, drag handles, subtitles, star rating inactive color) and adds widget tests to lock in the new theme-driven color expectations.
Changes:
- Update bottom-sheet drag-handle colors to use
colorScheme.onSurfaceVariant(no alpha) across multiple sheets. - Increase contrast for overflow menu item icon/text color and for
StarRatinginactive stars. - Add widget tests covering the light-theme “high contrast” behavior for overflow menu items, sheet drag handles, and star rating.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/widgets/overflow_menu_test.dart | Adds a light-theme assertion for overflow menu item icon/text color. |
| test/widgets/festival_menu_sheets_test.dart | Allows injecting a theme into test widgets and adds light-theme drag-handle color assertions. |
| test/widgets_test.dart | Adds a light-theme assertion for default inactive star color. |
| lib/widgets/star_rating.dart | Makes default inactive stars use onSurfaceVariant (no extra transparency). |
| lib/widgets/overflow_menu.dart | Applies explicit high-contrast colors to popup menu item icons/text. |
| lib/widgets/festival_menu_sheets.dart | Updates drag-handle colors to onSurfaceVariant (opaque). |
| lib/widgets/drink_list_section.dart | Changes subtitle/icon color to onSurface for higher contrast. |
| lib/screens/drinks_screen.dart | Updates drag-handle colors in filter/sort/style sheets to onSurfaceVariant (opaque). |
| lib/screens/about_screen.dart | Updates theme selector drag-handle color to onSurfaceVariant (opaque). |
Comments suppressed due to low confidence (1)
test/widgets/festival_menu_sheets_test.dart:401
- This drag-handle lookup scans all
Containers and matches on size/decoration, which is brittle and can break with unrelated widget tree changes. Prefer adding aKeyto the drag-handleContainerin the sheet widget and usingfind.byKeyhere.
}
Comment on lines
164
to
168
| Icon( | ||
| Icons.info_outline, | ||
| size: 14, | ||
| color: theme.colorScheme.onSurfaceVariant.withValues(alpha: 0.6), | ||
| color: theme.colorScheme.onSurface, | ||
| ), |
Comment on lines
+134
to
+138
| final handleContainer = tester.widget<Container>( | ||
| find.byKey(const Key('festival_selector_drag_handle')), | ||
| ); | ||
| final decoration = handleContainer.decoration! as BoxDecoration; | ||
|
|
Comment on lines
+301
to
305
|
|
||
| expect(decoration.color, lightTheme.colorScheme.onSurfaceVariant); | ||
| }); | ||
| }); | ||
|
|
Contributor
LCOV of commit
|
richardthe3rd
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
richardthe3rd
changed the title
richardthe3rd
changed the title
Contributor
🚀 Cloudflare Pages PreviewYour preview deployment is ready! Preview URL: https://copilot-improve-hamburger-me.staging-cambeerfestival.pages.dev This preview will be automatically updated when you push new commits to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent