chore(mise): bootstrap improvements and gitignore fixes - #265
Merged
Conversation
The npm backend's post-install reshimming step calls `mise` as a bare command, which fails in the bootstrap setup because the mise binary lives in .mise/ and is not on PATH. Adding ./bin to PATH via _.path makes the bootstrap script reachable as `mise` during tool installation. Fixes firebase-tools and playwright install failures with exit code 127.
playwright is now a task-level tool on the three test:e2e tasks so it only installs on demand rather than during every mise install. This keeps agent session startup lean (flutter + node only). firebase-tools is only needed for flutterfire configure, which is a human operation, so it moves to mise.human.toml.
The blanket *.lock rule was added in error by a previous agent session. It was incorrectly suppressing pubspec.lock (which should always be committed for apps to pin exact dependency versions) and mise.lock (which pins tool download URLs across platforms). package-lock.json remains explicitly ignored as before.
The template includes paths like /dev/benchmarks/, /packages/flutter/, linked_*.ds etc. that belong to the Flutter SDK monorepo, not an app. Also removes two exception rules pointing at SDK-internal paths. The iOS default.* exceptions are kept as they apply to app projects.
- .env / .env.* (Dart + Node templates) - logs directory (Node template) - .firebase/ (Node template; Firebase CLI hosting cache) - .idea/ (Android template; IntelliJ/Android Studio) - *.keystore alongside *.jks (Android template) - .cxx/, .externalNativeBuild/ (Android template; native build dirs) - *.hprof (Android template; heap dumps) - .npm, .eslintcache, npm-debug/yarn-debug log patterns (Node template)
richardthe3rd
changed the title
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the project’s mise setup to make the repo’s ./bin/mise wrapper discoverable on PATH during mise/npm installation steps, addressing npm backend reshimming failures during bootstrap.
Changes:
- Add
./bintoPATHviamise.toml[env] _.pathsomiseis callable as a bare command during installs. - Introduce/commit lockfiles (
mise.lock,pubspec.lock) to improve reproducibility of tool/dependency resolution. - Refactor dev tooling pins (Playwright) from a global
[tools]section into task/script-scoped tool requirements.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
mise.toml |
Adds ./bin to PATH via mise env configuration. |
bin/mise |
Updates the vendored mise bootstrap version/checksums. |
mise.lock |
Adds mise lockfile for pinned tool versions/checksums. |
mise.dev.toml |
Moves Playwright tool pin to task-level tools.* requirements. |
mise-tasks/setup/playwright |
Adds a task header tool pin for Playwright setup script. |
mise.human.toml |
Adds a pinned npm:firebase-tools entry for human environment installs. |
.gitignore |
Stops ignoring *.lock and broadens ignores (env files/logs/IDE/etc.). |
pubspec.lock |
Adds Dart/Flutter dependency lockfile for reproducible pub resolution. |
Comment on lines
30
to
33
| [tasks."test:e2e"] | ||
| description = "Run e2e tests with Playwright (headless mode)" | ||
| tools."npm:playwright" = "1.48.2" | ||
| run = ''' |
| @@ -1,5 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| #MISE description="Setup Playwright for e2e testing (install browsers and dependencies)" | |||
| #MISE tools."npm:playwright"="1.48.2" | |||
All e2e tasks use 'npm run' and 'npx playwright' which resolve to the local node_modules @playwright/test, not the mise-installed CLI. The mise tool pin was never called by any task and caused a version skew with package.json (1.48.2 vs resolved 1.57.0). Addresses Copilot review comments on PR #265.
Contributor
🚀 Cloudflare Pages PreviewYour preview deployment is ready! Preview URL: https://claude-evaluate-mise-bootstr.staging-cambeerfestival.pages.dev This preview will be automatically updated when you push new commits to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to the mise bootstrap setup and repository hygiene.
mise bootstrap
./binto PATH via[env] _.pathso npm's post-install reshimmingcan find the bootstrap's mise binary (fixes firebase-tools/playwright
install failures with exit code 127)
demand, not on every
mise installmise.human.toml— only needed forflutterfire configure, a human-only operationsetup:playwrightfile taskgitignore
pubspec.lockandmise.lock— previously suppressed by anerroneous
*.lockblanket rule added by a prior agent session/dev/,/packages/flutter/etc.)that don't apply to app projects
.env*,.firebase/,.idea/,*.keystore,*.hprof,.cxx/,.npm,.eslintcache, npm/yarn debug log patterns