fix(mise): add bash shebang to analyze and test task scripts - #274
Merged
Conversation
The analyze and test tasks use set -o pipefail, which is bash-specific. On systems where /bin/sh is dash or another POSIX shell (not bash), mise was invoking these scripts with sh and failing immediately with "Illegal option -o pipefail". Adding #!/usr/bin/env bash as the first line of each multiline run block causes mise to execute them with bash, matching the scripts' requirements.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes mise task execution on systems where /bin/sh is not Bash (e.g., dash) by ensuring the multiline test and analyze task scripts run under Bash, which is required for set -o pipefail.
Changes:
- Added a Bash shebang to the multiline
runblocks fortasks.testandtasks.analyze. - Prevents
/bin/shincompatibility failures (Illegal option -o pipefail) when running these tasks.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
🚀 Cloudflare Pages PreviewYour preview deployment is ready! Preview URL: https://fix-mise-task-shell-pipefail.staging-cambeerfestival.pages.dev This preview will be automatically updated when you push new commits to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analyze and test tasks use set -o pipefail, which is bash-specific.
On systems where /bin/sh is dash or another POSIX shell (not bash), mise
was invoking these scripts with sh and failing immediately with
"Illegal option -o pipefail".
Adding #!/usr/bin/env bash as the first line of each multiline run block
causes mise to execute them with bash, matching the scripts' requirements.