fix(og): map 'foreign beer' category to international-beer API endpoint - #290
Merged
Conversation
The OG preview handler derives the API endpoint name directly from the URL's category param. For foreign beer drinks the category field value is 'foreign beer' (with a space) but the API endpoint is 'international-beer', so the handler fetched a non-existent URL and silently fell back to the plain SPA — no OG metadata was injected. Add a CATEGORY_TO_ENDPOINT lookup in fetchDrinkData so 'foreign beer' resolves to 'international-beer.json', matching what the Flutter app uses when loading these drinks.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OG metadata generation for foreign beer drink URLs by translating the product category value to the corresponding data API endpoint before fetching preview data.
Changes:
- Adds a category-to-endpoint mapping for
foreign beer→international-beer. - Adds a unit test covering the mapped endpoint URL.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
functions/_lib/drink-preview.js |
Maps category values to API endpoint names before fetching drink data. |
functions/test/drink-preview.test.js |
Verifies foreign beer fetches international-beer.json. |
|
|
||
| export async function fetchDrinkData(festivalId, category) { | ||
| const url = `${DATA_BASE_URL}/${encodeURIComponent(festivalId)}/${encodeURIComponent(category)}.json`; | ||
| const endpoint = CATEGORY_TO_ENDPOINT[category] ?? category; |
Using bracket notation on a plain object lets inherited property names like 'constructor' or '__proto__' resolve to non-string values and produce a malformed upstream URL. Object.hasOwn checks own properties only, so unknown categories fall through to the original value safely.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OG preview handler derives the API endpoint name directly from the
URL's category param. For foreign beer drinks the category field value
is 'foreign beer' (with a space) but the API endpoint is
'international-beer', so the handler fetched a non-existent URL and
silently fell back to the plain SPA — no OG metadata was injected.
Add a CATEGORY_TO_ENDPOINT lookup in fetchDrinkData so 'foreign beer'
resolves to 'international-beer.json', matching what the Flutter app
uses when loading these drinks.