ci: fix scripts dep coverage gap and wrong self-reference path - #373
Merged
Conversation
- Add scripts/** to deploy-worker.yml path triggers so dependabot PRs bumping ajv/ajv-formats route through validate-festivals instead of silently skipping all CI jobs - Add scripts/** to the festivals path filter in the changes job so validate-festivals actually runs on those PRs - Fix self-referencing path filter: was cloudflare-worker.yml (wrong filename), now correctly points to deploy-worker.yml
The workflow manages the full Cloudflare Worker lifecycle (test, validate, deploy) — not just deployment. Rename to match what it manages, consistent with how the Pages workflows are named. Also update the workflow name field to match.
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the Cloudflare Worker CI workflow's path triggers and changes job filter so that PRs touching scripts/** (e.g., Dependabot bumps of ajv/ajv-formats used by scripts/validate-festivals.js) actually run validation instead of being silently skipped. Also renames the workflow's display name from "Deploy Worker" to "Cloudflare Worker".
Changes:
- Add
scripts/**to thepushandpull_requestpathstriggers. - Add
scripts/**to thefestivalsfilter in thechangesjob sovalidate-festivalsruns on script-only changes. - Rename the workflow's
name:from "Deploy Worker" to "Cloudflare Worker".
Comments suppressed due to low confidence (1)
.github/workflows/cloudflare-worker.yml:16
- The PR description states the self-referencing path filter was changed from
cloudflare-worker.ymltodeploy-worker.yml, but the diff shows the opposite (and there is nodeploy-worker.ymlfile in.github/workflows/). The self-references at lines 10 and 16 still correctly point tocloudflare-worker.yml, which matches the actual workflow filename. The PR description appears to be inverted/incorrect — please update it to reflect what the diff actually does (rename of the workflow display name from "Deploy Worker" to "Cloudflare Worker", plus addingscripts/**to triggers and the festivals filter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumping ajv/ajv-formats route through validate-festivals instead of
silently skipping all CI jobs
validate-festivals actually runs on those PRs
filename), now correctly points to deploy-worker.yml