-
Notifications
You must be signed in to change notification settings - Fork 3
fix(mise): unblock check in fresh worktrees, plus domain-architecture doc refresh #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5d83960
fix(mise): keep proto tools off the non-proto critical path
claude 8985795
fix(mise): exclude nested .mise and worktrees from shell file discovery
claude 239505f
docs: rewrite domain-architecture filter sections against current code
claude dcfda2e
docs(mise): clarify that scoping contains the failure, not fixes it
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping this one — the inconsistency is pre-existing and intentional, and my diff doesn't touch those lines (
git diff origin/main -- .claude/skills/build-and-env/SKILL.mdreturns nobuf@changes; I only edited the prose above the block).It's also not actually inconsistent. That's a verbatim captured log, and mise legitimately prints the resolved version in progress lines (
buf@1.70.0) and the requested spec in the error summary (aqua:bufbuild/buf@latest) — becauselatestresolved to 1.70.0 before the download failed. Changing the first line tobuf@latestwould make the snippet internally tidier but would no longer be a real mise transcript, which defeats the point of quoting it.Generated by Claude Code